Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display error messages for VariablesMapping (DMN/Objects API prefill) #4871

Open
stevenbal opened this issue Nov 29, 2024 · 0 comments · May be fixed by #5030
Open

Display error messages for VariablesMapping (DMN/Objects API prefill) #4871

stevenbal opened this issue Nov 29, 2024 · 0 comments · May be fixed by #5030
Assignees
@robinmolen
Labels
owner: den-haag topic: product-prefill
Milestone
Release 3.1.0

Comments

@stevenbal
Copy link
Contributor

From #4696 (comment)

The VariableMapping component currently doesn't show error messages that are passed to it (both for DMN configuration and Objects API prefill
@stevenbal stevenbal mentioned this issue Nov 29, 2024
Merged
9 tasks
@joeribekker joeribekker added this to the Release 3.0 milestone Dec 2, 2024
@robinmolen robinmolen moved this from Todo to In Progress in Development Jan 15, 2025
robinmolen added a commit that referenced this issue Jan 16, 2025
@robinmolen
✨ [#4871] Objects API variable mapping errors
a9d81d7
robinmolen added a commit that referenced this issue Jan 16, 2025
@robinmolen
💄 [#4871] Fixing errorlist styling in variable mapping
32aa1d0 
Because the inputs in the variable mapping don't have inline labels, the errorlist placement doesn't have to be compensated.
robinmolen added a commit that referenced this issue Jan 16, 2025
@robinmolen
✨ [#4871] Allow FormRow to hide error styling
41cc0a6 
Normally, when the formRow or a child component receives errors, the 'errors' classname is added. This in turn adds basic "error" styling to the underlying inputs.

In situations where multiple inputs are placed in 1 FormRow, and 1 input receives an error, this results in all inputs showing error styling.
robinmolen added a commit that referenced this issue Jan 16, 2025
@robinmolen
✨ [#4871] Only show error styling on inputs with errors
56ed345
robinmolen added a commit that referenced this issue Jan 16, 2025
@robinmolen
💄 [#4871] Display DMN config error messages above inputs
339b041 
Ensure that the error messages for the DMN configuration are placed above the inputs
robinmolen added a commit that referenced this issue Jan 16, 2025
@robinmolen
✨ [#4871] Show error message on DMN configuration
1fb690d
@robinmolen robinmolen linked a pull request Jan 22, 2025 that will close this issue
Showing error messages in variable mapping #5030
Open
10 tasks
@robinmolen robinmolen linked a pull request Jan 22, 2025 that will close this issue
Open
10 tasks
robinmolen added a commit that referenced this issue Jan 22, 2025
@robinmolen
✨ [#4871] Objects API variable mapping errors
f96a9f2
robinmolen added a commit that referenced this issue Jan 22, 2025
@robinmolen
💄 [#4871] Fixing errorlist styling in variable mapping
1c184df 
Because the inputs in the variable mapping don't have inline labels, the errorlist placement doesn't have to be compensated.
robinmolen added a commit that referenced this issue Jan 22, 2025
@robinmolen
✨ [#4871] Allow FormRow to hide error styling
358c8ca 
Normally, when the formRow or a child component receives errors, the 'errors' classname is added. This in turn adds basic "error" styling to the underlying inputs.

In situations where multiple inputs are placed in 1 FormRow, and 1 input receives an error, this results in all inputs showing error styling.
robinmolen added a commit that referenced this issue Jan 22, 2025
@robinmolen
✨ [#4871] Only show error styling on inputs with errors
3520928
robinmolen added a commit that referenced this issue Jan 22, 2025
@robinmolen
💄 [#4871] Display DMN config error messages above inputs
7298c7a 
Ensure that the error messages for the DMN configuration are placed above the inputs
robinmolen added a commit that referenced this issue Jan 22, 2025
@robinmolen
✨ [#4871] Show error message on DMN configuration
b6669fb
robinmolen added a commit that referenced this issue Jan 22, 2025
@robinmolen
🌐 [#4871] Translation for DMN config error message
d379c54
robinmolen added a commit that referenced this issue Jan 22, 2025
@robinmolen
✅ [#4871] Add storybook for variableMapping with validation errors
481cf6b
robinmolen added a commit that referenced this issue Jan 23, 2025
@robinmolen
✨ [#4871] Show error message on DMN configuration
15a5497
robinmolen added a commit that referenced this issue Jan 23, 2025
@robinmolen
🌐 [#4871] Translation for DMN config error message
db428b8
robinmolen added a commit that referenced this issue Jan 23, 2025
@robinmolen
✅ [#4871] Add storybook for variableMapping with validation errors
60bf1e3
robinmolen added a commit that referenced this issue Jan 23, 2025
@robinmolen
✅ [#4871] Logic tab test for dmn evaluation without config
cd4ae7f
@robinmolen robinmolen moved this from In Progress to Implemented in Development Jan 23, 2025
robinmolen added a commit that referenced this issue Jan 28, 2025
@robinmolen
✅ [#4871] Storybook tests for variableMapping and evaluate DMN with e…
d1ed227 
…rrors
robinmolen added a commit that referenced this issue Jan 29, 2025
@robinmolen
✨ [#4871] Objects API variable mapping errors
0835d23
robinmolen added a commit that referenced this issue Jan 29, 2025
@robinmolen
💄 [#4871] Fixing errorlist styling in variable mapping
b6f59a9 
Because the inputs in the variable mapping don't have inline labels, the errorlist placement doesn't have to be compensated.
robinmolen added a commit that referenced this issue Jan 29, 2025
@robinmolen
✨ [#4871] Allow FormRow to hide error styling
299babe 
Normally, when the formRow or a child component receives errors, the 'errors' classname is added. This in turn adds basic "error" styling to the underlying inputs.

In situations where multiple inputs are placed in 1 FormRow, and 1 input receives an error, this results in all inputs showing error styling.
robinmolen added a commit that referenced this issue Jan 29, 2025
@robinmolen
✨ [#4871] Only show error styling on inputs with errors
2fc09c5
robinmolen added a commit that referenced this issue Jan 29, 2025
@robinmolen
💄 [#4871] Display DMN config error messages above inputs
5a1db6d 
Ensure that the error messages for the DMN configuration are placed above the inputs
robinmolen added a commit that referenced this issue Jan 29, 2025
@robinmolen
✨ [#4871] Show error message on DMN configuration
c80a916
robinmolen added a commit that referenced this issue Jan 29, 2025
@robinmolen
🌐 [#4871] Translation for DMN config error message
7691adf
robinmolen added a commit that referenced this issue Jan 29, 2025
@robinmolen
✅ [#4871] Storybook tests for variableMapping and evaluate DMN with e…
78dd068 
…rrors
robinmolen added a commit that referenced this issue Jan 29, 2025
@robinmolen
💄 [#4871] Display DMN config error messages above inputs
4309f99 
Ensure that the error messages for the DMN configuration are placed above the inputs
robinmolen added a commit that referenced this issue Jan 29, 2025
@robinmolen
✨ [#4871] Show error message on DMN configuration
bc92cea
robinmolen added a commit that referenced this issue Jan 29, 2025
@robinmolen
🌐 [#4871] Translation for DMN config error message
e7fa3c1
robinmolen added a commit that referenced this issue Jan 29, 2025
@robinmolen
✅ [#4871] Storybook tests for variableMapping and evaluate DMN with e…
a6173e8 
…rrors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinmolen robinmolen

Labels
owner: den-haag topic: product-prefill
Projects
Development
Status: Implemented
Milestone
Release 3.1.0
Development

Successfully merging a pull request may close this issue.

Showing error messages in variable mapping open-formulieren/open-forms
4 participants
@joeribekker @sergei-maertens @stevenbal @robinmolen