Showing error messages in variable mapping #5030
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5030 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 770 770
Lines 26489 26489
Branches 3453 3453
=======================================
Hits 25618 25618
Misses 607 607
Partials 264 264 ☔ View full report in Codecov by Sentry. |
robinmolen
force-pushed
the
feature/4871-error-messages-for-variable-mapping
branch
2 times, most recently
from
481cf6b to
cd4ae7f
Compare
sergei-maertens
requested changes
Jan 27, 2025
There was a problem hiding this comment.
I don't think this is the most elegant code but it would be hypocritical to expect that, given how we work with validation errors in this codebase. A thorough cleanup/rewrite is in order for some time - when we build a dedicated admin interface instead of lumping everything in the django admin.
robinmolen
force-pushed
the
feature/4871-error-messages-for-variable-mapping
branch
from
cd4ae7f to
d1ed227
Compare
Because the inputs in the variable mapping don't have inline labels, the errorlist placement doesn't have to be compensated.
Normally, when the formRow or a child component receives errors, the 'errors' classname is added. This in turn adds basic "error" styling to the underlying inputs. In situations where multiple inputs are placed in 1 FormRow, and 1 input receives an error, this results in all inputs showing error styling.
robinmolen
force-pushed
the
feature/4871-error-messages-for-variable-mapping
branch
from
d1ed227 to
78dd068
Compare
Ensure that the error messages for the DMN configuration are placed above the inputs
robinmolen
force-pushed
the
feature/4871-error-messages-for-variable-mapping
branch
from
78dd068 to
a6173e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4871
Changes
Showing error messages in the variable mapping for Objects API and DMN.
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shDockerfile/scripts
./binfolderCommit hygiene