Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessible textual alternative for PDF logo #5052

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

robinmolen
Copy link
Contributor

Part of #4622 #5047

Changes

The previous textual alternative, using aria-label, wasn't targetable by screen readers (tested using the macOS VoiceOver screen reader). By providing the textual alternative as real content the screen reader can find and read the content.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

The previous textual alternative, using `aria-label`, wasn't targetable by screen readers (tested using the macOS VoiceOver screen reader).
By providing the textual alternative as real content the screen reader can find and read the content.
@robinmolen robinmolen requested a review from vaszig January 28, 2025 15:38
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.67%. Comparing base (1658eca) to head (d9b2299).
Report is 65 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5052   +/-   ##
=======================================
  Coverage   96.67%   96.67%           
=======================================
  Files         765      765           
  Lines       26131    26131           
  Branches     3407     3407           
=======================================
  Hits        25262    25262           
  Misses        606      606           
  Partials      263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this visually but had difficulties on testing this with my screen reader (orca).

@sergei-maertens sergei-maertens merged commit c70e33f into master Feb 5, 2025
32 checks passed
@sergei-maertens sergei-maertens deleted the a11y/4622-textual-alternative-for-pdf-logo branch February 5, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants