Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI e2e test input validation failure in addressNL #5054

Merged

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Jan 29, 2025

Closes #...

Changes

[Describe the changes here]

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig vaszig marked this pull request as draft January 29, 2025 07:53
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.71%. Comparing base (65097fa) to head (c644660).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5054   +/-   ##
=======================================
  Coverage   96.71%   96.71%           
=======================================
  Files         770      770           
  Lines       26489    26489           
  Branches     3453     3453           
=======================================
  Hits        25618    25618           
  Misses        607      607           
  Partials      264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig marked this pull request as ready for review January 29, 2025 08:08
@vaszig vaszig marked this pull request as draft January 29, 2025 08:48
@vaszig vaszig marked this pull request as ready for review January 29, 2025 09:49
@sergei-maertens sergei-maertens merged commit 934bb7a into master Jan 29, 2025
38 checks passed
@sergei-maertens sergei-maertens deleted the fix/ci-failing-in-e2e-input-validation-tests branch January 29, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants