Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AddressNL ci e2e test #5061

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Fix AddressNL ci e2e test #5061

merged 1 commit into from
Jan 30, 2025

Conversation

robinmolen
Copy link
Contributor

Linked to SDK PR #790

Changes

Fix for ci e2e test

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.71%. Comparing base (934bb7a) to head (ca8e5f7).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5061   +/-   ##
=======================================
  Coverage   96.71%   96.71%           
=======================================
  Files         770      770           
  Lines       26489    26489           
  Branches     3453     3453           
=======================================
  Hits        25618    25618           
  Misses        607      607           
  Partials      264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1028,7 +1028,7 @@ def test_required_field(self):
"houseLetter": "",
"houseNumberAddition": "",
},
expected_ui_error="Dit veld mag niet leeg zijn.",
expected_ui_error="Het verplichte veld Required AddressNL is niet ingevuld.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text (Het verplichte veld Required AddressNL is niet ingevuld.) was failing and I changed it to Dit veld mag niet leeg zijn.. Just wanted to let you know what I did and it still failed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the problem was in the SDK.. So with that issue fixed, the error message is once again "Het verplichte veld Required AddressNL is niet ingevuld"

I think that the problem was what information was used (by the SDK) for the validation..

@robinmolen robinmolen merged commit bc1cc34 into master Jan 30, 2025
31 of 32 checks passed
@robinmolen robinmolen deleted the fix/addressnl-e2e-ci-test branch January 30, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants