Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5034] Fix object ownership in Objects API #5062

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Jan 30, 2025

Closes #5034

Changes

  • Added regression tests
  • Updated object ownership validation to be triggered only when the object needs update

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig vaszig added the needs-backport Fix must be backported to stable release branch label Jan 30, 2025
@vaszig vaszig force-pushed the fix/5034-update-existing-object-in-Objects-api-expects-authattribute branch from 9e3e6ba to eeeabb9 Compare January 30, 2025 14:04
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.72%. Comparing base (bc1cc34) to head (8e71ffc).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5062      +/-   ##
==========================================
+ Coverage   96.71%   96.72%   +0.01%     
==========================================
  Files         770      770              
  Lines       26489    26491       +2     
  Branches     3453     3454       +1     
==========================================
+ Hits        25618    25623       +5     
+ Misses        607      606       -1     
+ Partials      264      262       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@robinmolen robinmolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of nit picking :)

Besides this, it looks good to me!

@vaszig vaszig force-pushed the fix/5034-update-existing-object-in-Objects-api-expects-authattribute branch from eeeabb9 to 8e71ffc Compare January 30, 2025 15:41
@sergei-maertens sergei-maertens merged commit 9f92893 into master Jan 31, 2025
32 checks passed
@sergei-maertens sergei-maertens deleted the fix/5034-update-existing-object-in-Objects-api-expects-authattribute branch January 31, 2025 07:53
sergei-maertens pushed a commit that referenced this pull request Jan 31, 2025
@sergei-maertens
Copy link
Member

Backported to 3.0.x in b74ea05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object registration plugin expects Auth Attribute Path when "update existing object" is not set.
3 participants