-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#5034] Fix object ownership in Objects API #5062
[#5034] Fix object ownership in Objects API #5062
Conversation
9e3e6ba
to
eeeabb9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5062 +/- ##
==========================================
+ Coverage 96.71% 96.72% +0.01%
==========================================
Files 770 770
Lines 26489 26491 +2
Branches 3453 3454 +1
==========================================
+ Hits 25618 25623 +5
+ Misses 607 606 -1
+ Partials 264 262 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of nit picking :)
Besides this, it looks good to me!
src/openforms/registrations/contrib/objects_api/tests/test_backend_v1.py
Outdated
Show resolved
Hide resolved
eeeabb9
to
8e71ffc
Compare
Backported to 3.0.x in b74ea05 |
Closes #5034
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Dockerfile/scripts
./bin
folderCommit hygiene