Allow replacing all instances of a texture with one texture #3234
Conversation
|
Can one of the admins verify this patch? |
|
Is there anyway you can add a key into the config json for this. Unsure if people think its best to enable or disable this by default. There are some packs that currently depend on this double swap mechanic to work, this seems like a nice feature but I dont see why we couldn't support both options
|
|
As I explained in my initial comment, if you put your replacements into the level-specific folder (like in the old system), it will take priority over any replacements that are in the '_all' folder. And every texture pack that was made before this change will still behave the same way. The only change is that now you can also put stuff into an '_all' folder if you want. |
|
Ah yes, just got off work and forgot how to read, I even peaked the code changes and it didnt connect with me... I should take a nap |
There are art groups that are present in multiple levels, and that means that also their textures are present in multiple levels. With texture replacement, currently we need to make replacements for all instances if we want it replaced everywhere, but this is not ideal, especially when you make changes to your replacement texture and now you have to put it in each folder again.
I added a way to replace all instances of a texture, by letting texture-replacer people put their replacements into an '_all' folder. I set up the logic in such a way that if you have a replacement for the texture in its corresponding folder, it will take priority over a replacement that you placed into the '_all' folder.
I personally found this very useful for replacing guard textures. The guards appear in a lot of levels. But ideally you want them to look the same everywhere. And that is why I looked into this and made a PR.
Oh and I changed what is printed in the 'Replacing ' part because it was printing the path to our replacement, which didn't look nicely when several textures got replaced by the same replacement from the '_all' folder. So now it will print the original texture's page and name, I think this information is more useful anyway.