[decompiler] as-type and font method support
#3855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hat-Kid
reviewed
Feb 1, 2025
goal_src/jak1/kernel/gcommon.gc
Outdated
| "If this is the specified type, return this cast to that type. Otherwise, return #f." | ||
| (with-gensyms (obj) | ||
| `(the ,type (let ((,obj ,this)) | ||
| (if (type? ,obj ,type) |
There was a problem hiding this comment.
Jak 1 doesn't have type?, only type-type?.
There was a problem hiding this comment.
oops - I should have left this. The decompiler doens't recognize the jak 1 version yet.
|
Probably closes #1280 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
as-typemacro, and detecting inline font methods. This works in all three games but I've only updated jak 3's goal_src for now. Eventually I will go back and work through the others, but I want to get more decompiler features in first.