Fix 10689: Added Powerbi Datamodels #11923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backend
documentation
Passing run #24004 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
pmbrull
reviewed
Jun 13, 2023
| class LineageEnum(Enum): | ||
| TABLE = "table" | ||
| DASHBOARD = "dashboard" | ||
| DASHBOARDDATAMODEL = "dashboardDataModel" |
There was a problem hiding this comment.
nit - I'd rename it to something a bit more readable: DASHBOARD_DATAMODEL
| type="table" | ||
| if isinstance(from_entity, Table) | ||
| else "dashboardDataModel", | ||
| type=LineageEnum[from_entity.__class__.__name__.upper()].value, |
There was a problem hiding this comment.
I think this looks like a bit strange use of an Enum. If what we want is to use to get the type from the entity class name, we could have a clearer intent if we use a dictionary, WDYT?
There was a problem hiding this comment.
Ok I'll use a dictionary here
ingestion/src/metadata/ingestion/source/dashboard/powerbi/metadata.py
Outdated
Show resolved
Hide resolved
|
[open-metadata-ingestion] SonarCloud Quality Gate failed. |
pmbrull
approved these changes
Jun 14, 2023
|
[OpenMetadata-Platform] Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #10689
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>