-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limit testing to oqsprovider #611
Conversation
Signed-off-by: Michael Baentsch <[email protected]>
IMO OQS provider testing should test primarily the OQS provided implementations. Of course once some PQ algorithm implementations are implemented in OpenSSL code itself, it might make sense to have some kind of interoperability tests between the respective OQS provider and OpenSSL provider implementations as part of OQS provider tests. I would wait with these tests for these OpenSSL implementations to be at least merged to the OpenSSL master branch though. |
Another option would be to execute the tests that work with both OpenSSL PQ implementation and OQS provider implementation twice - once with the propquery set and once without it. |
Signed-off-by: Michael Baentsch <[email protected]>
But only tests that really are expected to be provider independent. In particular, tests that depend on provider-specific properties need to load the algorithm from just the provider in question. |
I agree, we should ensure as first priority that the full functionality of oqs-provider is tested. |
This is what this PR (now) does. Please check and approve. |
Fixes #609 .
Question to the community, particularly @mattcaswell @t8m @SWilson4 : Should we limit all testing to
oqsprovider
or still allow interaction with other implementations for the same algorithms in different providers (propq==NULL) as is still possible for some tests as per this PR? See also #610 .Advantage: Other code also gets tested.
Disadvantage:
oqsprovider
code may not get tested.The latter leads me to prefer extending this PR to limit all testing completely to
provider=oqsprovider
and not just of experimental features that are OQS-specific as with this the PR as done initially.