Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit testing to oqsprovider #611

Merged
merged 2 commits into from
Jan 6, 2025
Merged

limit testing to oqsprovider #611

merged 2 commits into from
Jan 6, 2025

Conversation

baentsch
Copy link
Member

@baentsch baentsch commented Jan 3, 2025

Fixes #609 .

Question to the community, particularly @mattcaswell @t8m @SWilson4 : Should we limit all testing to oqsprovider or still allow interaction with other implementations for the same algorithms in different providers (propq==NULL) as is still possible for some tests as per this PR? See also #610 .

Advantage: Other code also gets tested.
Disadvantage: oqsprovider code may not get tested.

The latter leads me to prefer extending this PR to limit all testing completely to provider=oqsprovider and not just of experimental features that are OQS-specific as with this the PR as done initially.

@t8m
Copy link

t8m commented Jan 3, 2025

IMO OQS provider testing should test primarily the OQS provided implementations. Of course once some PQ algorithm implementations are implemented in OpenSSL code itself, it might make sense to have some kind of interoperability tests between the respective OQS provider and OpenSSL provider implementations as part of OQS provider tests. I would wait with these tests for these OpenSSL implementations to be at least merged to the OpenSSL master branch though.

@t8m
Copy link

t8m commented Jan 3, 2025

Another option would be to execute the tests that work with both OpenSSL PQ implementation and OQS provider implementation twice - once with the propquery set and once without it.

Signed-off-by: Michael Baentsch <[email protected]>
@baentsch baentsch changed the title limit oqs-specific tests to oqsprovider limit testing to oqsprovider Jan 3, 2025
@baentsch baentsch requested a review from a team January 3, 2025 11:04
@vdukhovni
Copy link

Another option would be to execute the tests that work with both OpenSSL PQ implementation and OQS provider implementation twice - once with the propquery set and once without it.

But only tests that really are expected to be provider independent. In particular, tests that depend on provider-specific properties need to load the algorithm from just the provider in question.

@SWilson4
Copy link
Member

SWilson4 commented Jan 3, 2025

Fixes #609 .

Question to the community, particularly @mattcaswell @t8m @SWilson4 : Should we limit all testing to oqsprovider or still allow interaction with other implementations for the same algorithms in different providers (propq==NULL) as is still possible for some tests as per this PR? See also #610 .

Advantage: Other code also gets tested. Disadvantage: oqsprovider code may not get tested.

The latter leads me to prefer extending this PR to limit all testing completely to provider=oqsprovider and not just of experimental features that are OQS-specific as with this the PR as done initially.

I agree, we should ensure as first priority that the full functionality of oqs-provider is tested.

@baentsch
Copy link
Member Author

baentsch commented Jan 4, 2025

I agree, we should ensure as first priority that the full functionality of oqs-provider is tested.

This is what this PR (now) does. Please check and approve.

@baentsch baentsch merged commit 35529a0 into main Jan 6, 2025
56 checks passed
@baentsch baentsch deleted the mb-fix609 branch January 6, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing not sufficiently restricted to oqsprovider
4 participants