Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making improvements to the consistency and functionality of the shell code #30

Closed
wants to merge 3 commits into from

Conversation

aaronbog
Copy link
Collaborator

shell/utils.py:

shell/shell.py:

  1. rewritten shell_out function
  • using true to determine the value of the success return value
  • refactor such that all commands can use the same Popen structure for consistency
  • output_is_log=True now takes into account the timeout variable (this is the use of the multiprocessing package)
  • output_is_log=True now takes into account the ignore_ret_codes
  • made allowed exit codes add their stderr to the output instead of overwriting it
  • added split_arguments=False as an argument so pipe_shell_out can be simplified
  1. rewritten pipe_shell_out function
  • rewrote the implementation using shell_out and the new split_arguments argument

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant