-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmd/telemetrygen] Export telemetrygen functions for testing #37044
base: main
Are you sure you want to change the base?
[cmd/telemetrygen] Export telemetrygen functions for testing #37044
Conversation
… `Start` with the appropriate config
…rygen-funcs-for-tests
…rygen-funcs-for-tests
This goes hand in hand with #37003 in order to help own and maintain this API. I read about chloggen, but haven't used it before so I copied the template and made a version manually. I hope I did that properly. |
…rygen-funcs-for-tests
…rygen-funcs-for-tests
…rygen-funcs-for-tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #37044 +/- ##
==========================================
- Coverage 79.60% 79.57% -0.03%
==========================================
Files 2250 2250
Lines 211890 211951 +61
==========================================
- Hits 168676 168668 -8
- Misses 37540 37608 +68
- Partials 5674 5675 +1 ☔ View full report in Codecov by Sentry. |
Description
This PR addresses #36984 in order to open up telemetrygen to be used by golang tests and generate varying amounts of telemetry in code to support use cases which don't rely on external tools.
Testing
Added to the E2E tests to ensure consistent API specs. Additionally had to adjust log and metric exporter instantiation slightly due to a race condition with an
err
variable.