Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Health] Include what you use, part 6 #3216

Merged
merged 8 commits into from
Jan 8, 2025

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Dec 18, 2024

Contributes to #2054

Changes

  • The github CI was upgraded recently to run on Ubuntu 24.04.1, a bump from 22.04.5
  • As a result, the iwyu tool was upgraded to version 8.21-1build2, a bump from 8.17-1
  • include-what-you-use reports more diagnostics in version 8.21, causing the number of warnings to increase, after the upgrade in CI runners.

This fix resolves the new warnings reported by iwyu 8.21.

The warning count was 177 before this fix, it is now down to 5 (to resolve separately).

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 695f500
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/677e365ec7ad4d00080013e2

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.16%. Comparing base (c33f800) to head (695f500).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3216   +/-   ##
=======================================
  Coverage   88.16%   88.16%           
=======================================
  Files         198      198           
  Lines        6224     6224           
=======================================
  Hits         5487     5487           
  Misses        737      737           
Files with missing lines Coverage Δ
exporters/memory/src/in_memory_metric_data.cc 85.00% <ø> (ø)
...xporters/memory/test/in_memory_metric_data_test.cc 100.00% <ø> (ø)
...ters/memory/test/in_memory_metric_exporter_test.cc 100.00% <ø> (ø)
...orters/memory/test/in_memory_span_exporter_test.cc 100.00% <ø> (ø)
exporters/ostream/src/log_record_exporter.cc 97.06% <ø> (ø)
...porters/ostream/src/log_record_exporter_factory.cc 100.00% <ø> (ø)
exporters/ostream/test/ostream_log_test.cc 96.18% <ø> (ø)
exporters/ostream/test/ostream_metric_test.cc 100.00% <ø> (ø)
exporters/ostream/test/ostream_span_test.cc 100.00% <ø> (ø)
sdk/src/logs/batch_log_record_processor.cc 89.29% <ø> (ø)
... and 17 more

@marcalff marcalff marked this pull request as ready for review January 7, 2025 22:21
@marcalff marcalff requested a review from a team as a code owner January 7, 2025 22:21
@marcalff marcalff added the pr:please-review This PR is ready for review label Jan 7, 2025
@marcalff marcalff changed the title Include what you use, part 6 [Code Health] Include what you use, part 6 Jan 8, 2025
@marcalff marcalff merged commit e5a1a15 into open-telemetry:main Jan 8, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:please-review This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants