Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEMCONV] Metrics are incorrectly prefixed with metric. #3228

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Jan 6, 2025

Fixes #3226

Changes

Please provide a brief description of the changes here.

  • Fixed the semconv code generation for metrics, to emit the proper metric name

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 23c7a98
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/677c4e0da0b96700082c26f3

@marcalff marcalff marked this pull request as ready for review January 6, 2025 21:47
@marcalff marcalff requested a review from a team as a code owner January 6, 2025 21:47
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.16%. Comparing base (bb68f49) to head (23c7a98).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3228   +/-   ##
=======================================
  Coverage   88.16%   88.16%           
=======================================
  Files         198      198           
  Lines        6224     6224           
=======================================
  Hits         5487     5487           
  Misses        737      737           

@marcalff marcalff merged commit 3b89346 into open-telemetry:main Jan 7, 2025
57 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Jan 7, 2025
[SEMCONV] Metrics are incorrectly prefixed with `metric.` (open-telemetry#3228)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SEMCONV] Metrics are incorrectly prefixed with metric.
2 participants