Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Add OTLP/file exporter for dll and examples #3231

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

owent
Copy link
Member

@owent owent commented Jan 8, 2025

Fixes #3225

Changes

  • Add otlp for examples when include OTLP/file exporters only
  • Link OTLP/file exporters into standardalone dll.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team as a code owner January 8, 2025 03:48
Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit c9474fb
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/677df573693f150008083026

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.16%. Comparing base (3b89346) to head (c9474fb).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3231   +/-   ##
=======================================
  Coverage   88.16%   88.16%           
=======================================
  Files         198      198           
  Lines        6224     6224           
=======================================
  Hits         5487     5487           
  Misses        737      737           

@marcalff marcalff changed the title Add OTLP/file exporter for dll and examples [BUILD] Add OTLP/file exporter for dll and examples Jan 8, 2025
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff merged commit c33f800 into open-telemetry:main Jan 8, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-DWITH_OTLP_FILE=ON -DWITH_EXAMPLES=ON is not compiling the file_metric_main.cc
2 participants