Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reporter: fix samples.SetLocationsLength #317

Closed
wants to merge 1 commit into from
Closed

reporter: fix samples.SetLocationsLength #317

wants to merge 1 commit into from

Conversation

florianl
Copy link
Contributor

Fixes #262

@florianl florianl added the bug Something isn't working label Jan 21, 2025
@florianl florianl requested review from a team as code owners January 21, 2025 08:53
@rockdaboot
Copy link
Contributor

Can you explain why sample.SetLocationsLength(int32(len(traceInfo.FrameTypes))) is wrong?
Because it looks like that a location for every frame is added with loc := profile.LocationTable().AppendEmpty().

@florianl
Copy link
Contributor Author

In theory, a stack trace should contain only frames of type native, kernel or some kind of interpreter. But with the option -send-error-frames artificial frames are added to the stack trace to report known (unwinding) error codes. As the error code for these special frames are encoded within message Location, it make sense to keep the current behavior, until there is an agreement to report these special information.

@florianl florianl closed this Jan 21, 2025
@florianl florianl deleted the issue-262 branch January 22, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sample.LocationsLength is mis calculated
2 participants