Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(instrumentation-fastify): deprecate instrumentation in favor of @fastify/otel #2651

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

Ownership of the instrumentation is moving to https://github.com/fastify/otel. Fastify will provide and maintain an official instrumentation (@fastify/otel) going forward.

See #2647

Short description of the changes

This PR deprecates @opentelemetry/instrumentation-fastify (once merged, I will follow up with deprecation on npm)

@pichlermarc pichlermarc added pkg:instrumentation-fastify has:sponsor This package or feature has a sponsor that has volunteered to review PRs and respond to questions labels Jan 16, 2025
@pichlermarc pichlermarc requested a review from a team as a code owner January 16, 2025 15:44
@github-actions github-actions bot added the pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. label Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (e57f3e4) to head (8bcc68b).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2651      +/-   ##
==========================================
+ Coverage   90.79%   90.96%   +0.17%     
==========================================
  Files         169      172       +3     
  Lines        8061     8137      +76     
  Branches     1646     1649       +3     
==========================================
+ Hits         7319     7402      +83     
+ Misses        742      735       -7     
Files with missing lines Coverage Δ
...try-instrumentation-fastify/src/instrumentation.ts 95.38% <ø> (ø)

... and 8 files with indirect coverage changes


If total installation size is not constrained, it is recommended to use the [`@opentelemetry/auto-instrumentations-node`](https://www.npmjs.com/package/@opentelemetry/auto-instrumentations-node) bundle with [@opentelemetry/sdk-node](`https://www.npmjs.com/package/@opentelemetry/sdk-node`) for the most seamless instrumentation experience.
This module provides automatic instrumentation for the [`fastify`](https://www.fastify.io/) module, which may be loaded using the [`@opentelemetry/sdk-trace-node`](https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-sdk-trace-node) package.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This module provides automatic instrumentation for the [`fastify`](https://www.fastify.io/) module, which may be loaded using the [`@opentelemetry/sdk-trace-node`](https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-sdk-trace-node) package.
This module provides automatic instrumentation for the [`fastify`](https://www.fastify.dev/) module, which may be loaded using the [`@opentelemetry/sdk-trace-node`](https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-sdk-trace-node) package.

@Eomm Eomm mentioned this pull request Jan 25, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has:sponsor This package or feature has a sponsor that has volunteered to review PRs and respond to questions pkg:instrumentation-fastify pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants