fix(api): clean up method signature

Co-authored-by: Godfrey Chan <[email protected]>
open-telemetry · Jan 23, 2025 · e36accc · e36accc
1 parent 074324b
commit e36accc
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/api/src/trace/NonRecordingSpan.ts b/api/src/trace/NonRecordingSpan.ts
@@ -81,8 +81,13 @@ export class NonRecordingSpan implements Span {
 
   // By default does nothing
   recordException(
-    _exception: Exception,
-    _attributesOrStartTime?: SpanAttributes | TimeInput,
-    _time?: TimeInput
-  ): void {}
+    exception: Exception,
+    time?: TimeInput
+  ): void;
+  recordException(
+    exception: Exception,
+    attributes: SpanAttributes | undefined,
+    time?: TimeInput
+  ): void;
+  recordException(): void {}
 }
diff --git a/api/src/trace/span.ts b/api/src/trace/span.ts
@@ -159,7 +159,11 @@ export interface Span {
    */
   recordException(
     exception: Exception,
-    attributes?: SpanAttributes,
+    time?: TimeInput
+  ): void;
+  recordException(
+    exception: Exception,
+    attributes: SpanAttributes | undefined,
     time?: TimeInput
   ): void;
 }