Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-trace-web): do not throw when passing extra options #5357

Merged

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Jan 22, 2025

Which problem is this PR solving?

Since #906 (experimental tracing) we've been throwing in the constructor due to a previous documentation error.
This PR now removes the throwing code to further align implementations for Node.js and Web. #5290

Type of change

  • not sure actually (does not add anything - it removes, but is not breaking, but also may affect users)

How Has This Been Tested?

  • Unit tests

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.63%. Comparing base (321c31f) to head (823b100).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5357   +/-   ##
=======================================
  Coverage   94.63%   94.63%           
=======================================
  Files         318      318           
  Lines        8036     8036           
  Branches     1685     1685           
=======================================
  Hits         7605     7605           
  Misses        431      431           

@pichlermarc pichlermarc marked this pull request as ready for review January 22, 2025 13:12
@pichlermarc pichlermarc requested a review from a team as a code owner January 22, 2025 13:12
@pichlermarc pichlermarc enabled auto-merge January 27, 2025 16:35
@pichlermarc pichlermarc added this pull request to the merge queue Jan 27, 2025
Merged via the queue into open-telemetry:main with commit 199fd8d Jan 27, 2025
15 checks passed
@pichlermarc pichlermarc deleted the feat/do-not-throw-constr branch January 27, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants