feat(instrumentation-grpc): monitor error events with events.errorMonitor #5369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
errorMonitor
should be preferred over'error'
event handlers for instrumentation, as the latter alters the behavior of the server if the user has not added their own error handler.Related to: #225. I'm not sure we want to close the issue based on this fix.
Short description of the changes
This commit updates instrumentation-grpc to utilize
errorMonitor
instead of'error'
event handlers. This makes the instrumented server behave more like it would without instrumentation.Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
'error'
handler count of the server.Checklist: