refactor(context-zone-peer-dep): fix eslint warnings #5371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/home/runner/work/opentelemetry-js/opentelemetry-js/packages/opentelemetry-context-zone-peer-dep/src/util.ts
22:39 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
Ref open-telemetry#5365
chancancode
commented
Jan 24, 2025
| * @param obj - The object to check. | ||
| */ | ||
| export function isListenerObject(obj: any = {}): boolean { |
There was a problem hiding this comment.
The parameter default seems pointless as that will just always return false. Removed it since this is a private utility not a public export.
chancancode
commented
Jan 24, 2025
| typeof obj.addEventListener === 'function' && | ||
| 'removeEventListener' in obj && | ||
| typeof obj.removeEventListener === 'function' |
There was a problem hiding this comment.
There are alternatives without changing the runtime code (which can impose a small runtime cost), but this seemed the most straightforward/clear, and doesn't seem like the micro performance cost should matter all that much.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5371 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 318 318
Lines 8052 8052
Branches 1694 1694
=======================================
Hits 7613 7613
Misses 439 439 |
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixed this eslint warning:
Ref #5365
Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: