Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(instrumentation-grpc): remove unused findIndex() function #5372

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 24, 2025

Which problem is this PR solving?

There is not a problem, but this appears to be unused code.

Fixes N/A

Short description of the changes

This commit removes the findIndex() function. This function appears to be unused and findIndex() is part of the language now.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Ran the test suite

Checklist:

  • Followed the style guidelines of this project

@cjihrig cjihrig requested a review from a team as a code owner January 24, 2025 21:49
This commit removes the findIndex() function. This function
appears to be unused and findIndex() is part of the language now.
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.62%. Comparing base (2a26d08) to head (8de94b1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5372      +/-   ##
==========================================
+ Coverage   94.54%   94.62%   +0.08%     
==========================================
  Files         318      318              
  Lines        8046     8038       -8     
  Branches     1688     1687       -1     
==========================================
- Hits         7607     7606       -1     
+ Misses        439      432       -7     
Files with missing lines Coverage Δ
...es/opentelemetry-instrumentation-grpc/src/utils.ts 95.55% <ø> (+12.53%) ⬆️

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@pichlermarc pichlermarc added this pull request to the merge queue Jan 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 27, 2025
@pichlermarc pichlermarc enabled auto-merge January 27, 2025 09:37
@pichlermarc pichlermarc added this pull request to the merge queue Jan 27, 2025
Merged via the queue into open-telemetry:main with commit bdc0e3a Jan 27, 2025
15 checks passed
@cjihrig cjihrig deleted the unused-fn branch January 27, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants