Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add kind enum type for aggregation_temporality that only allow two types #1769

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

xuan-cao-swi
Copy link
Contributor

Relates to #1742, #1555

Description

  1. Created two enum type (delta and cumulative) for aggregation_temporality based on OpenTelemetry::Trace::Status to make spec compliance.
  2. Set sum and histogram to have cumulative as default aggregation_temporality (issue 1555). For last_value, it's still delta because I think it's easier to keep the last value as the last value; and for drop, aggregation_temporality won't have any effects since it drops all data.
  3. Updated the test case that reflect the change.

Copy link
Contributor

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To do
Development

Successfully merging this pull request may close these issues.

2 participants