Work around open-telemetry/opentelemetry-swift#615 #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Static Linux SDK
semicoleon
requested review from
nachoBonafonte,
bryce-b and
vvydier
as code owners
…ad subclass on Apple platforms
|
@nachoBonafonte Understood! I went ahead made that change. I also added some tests to try to catch any reference cycle issues. |
nachoBonafonte
approved these changes
Feb 6, 2025
Please take a look at this test that is failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#615 is still an issue when building for Linux, and the PR in the swift project appears to have stalled. This PR makes the subclass of
Threada plain class with aThreadproperty that spawns a thread with a closure instead. This appears to work fine on macOS and Linux in my limited testing so far.I'm not sure if this PR should actually be merged, ideally the error would be resolved in Swift.
I also made a couple minor changes to support building with the Static Linux SDK as that made checking for Linux only compiler errors considerably easier.