Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

Update OTLP+Arrow exporter test for metrics data #16

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Nov 17, 2022

Description: Introduces usage of and test for otel-arrow-adapter metrics support, added in recent PRs in that repo.
The corresponding receiver support for metrics was added in #15.

Testing: Test coverage added.

Part of #22.

@jmacd jmacd requested review from lquerel and jaronoff97 November 17, 2022 00:07
Copy link

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the merge with my PR, you should add the logic to call the Close method for each Producer created.

Copy link
Contributor

@jaronoff97 jaronoff97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, seems to be some tests failing?

@jmacd jmacd merged commit b8fb1d5 into open-telemetry:main Nov 18, 2022
@jmacd jmacd deleted the jmacd/etest3 branch November 18, 2022 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants