Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_experimental returns true by default #570

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jerbly
Copy link
Contributor

@jerbly jerbly commented Jan 24, 2025

For issue #569 - Add include_stability config into semconv_grouped_attributes: is_experimental returns true by default.

@jerbly jerbly requested a review from a team as a code owner January 24, 2025 18:00
@@ -16,6 +16,7 @@ groups:
value: 'nice'
- id: idle
value: 'idle'
stability: stable
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note. For our internal codegen test to pass I now had to explicitly set this to stable!

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6%. Comparing base (a11060e) to head (70ad06f).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #570   +/-   ##
=====================================
  Coverage   74.5%   74.6%           
=====================================
  Files         51      51           
  Lines       3965    3965           
=====================================
+ Hits        2957    2959    +2     
+ Misses      1008    1006    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants