Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix openMF#1665: Filter error in AccountsFragment.kt fixed #2440

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

kmanikanta335
Copy link
Contributor

Fixes #1665

Please Add Screenshots If there are any UI changes.

1665.mp4

Please make sure these boxes are checked before submitting your pull request - thanks!

  • ✅ Apply the AndroidStyle.xml style template to your code in Android Studio.

  • ✅ Run the unit tests with ./gradlew check to make sure you didn't break anything

  • ✅ If you have multiple commits please combine them into one commit by squashing them.

@kmanikanta335
Copy link
Contributor Author

@PratyushSingh07 pls review it

@PratyushSingh07
Copy link
Collaborator

Also , I have a doubt . If i click on the filter button without selecting an option should there be any UI layout? I mean if i haven't selected any filter then ideally i should see the screen as it is. Why will i need a UI layout with the message "No Accounts Found" ?

@kmanikanta335
Copy link
Contributor Author

@PratyushSingh07 yes you are right
but there is "cancel" button , when it is pressed then the layout remains as it is.
Basically error layout is just to show that there are no options selected.

cancle.mp4

By the way I am Manikanta from Dayananda Sagar college of Engineering (5th sem)
I too want crack G'SoC 2024 like you cracked G'SoC 2023
can you please tell me will Mifos-Mobile take part in gsoc 2024

@PratyushSingh07
Copy link
Collaborator

PratyushSingh07 commented Nov 16, 2023

If i click on filter button without selecting any option then seeing the screen as it is should be a better alternative.
@kmanikanta335 you can not predict if mifos mobile or any other project will participate in GSoC 24. It depends on priority of the project and also a lot of other factors.

Also, do not resolve the conversation . let the reviewer do it

@kmanikanta335
Copy link
Contributor Author

@PratyushSingh07 I have made screen remain same after selecting no options in filter
pls review it

filter.mp4

fix openMF#1665: Filter error in AccountsFragment.kt fixed

fix openMF#1665: Filter error in AccountsFragment.kt fixed

fix openMF#1665: Filter error in AccountsFragment.kt fixed

fix openMF#1665: Filter error in AccountsFragment.kt fixed
@kmanikanta335
Copy link
Contributor Author

@therajanmaurya pls merge this too

@PratyushSingh07
Copy link
Collaborator

LGTM we can merge this @therajanmaurya

@therajanmaurya therajanmaurya merged commit dbfcd8c into openMF:development Jan 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter error in Account Fragment
3 participants