-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix openMF#1665: Filter error in AccountsFragment.kt fixed #2440
Conversation
@PratyushSingh07 pls review it |
app/src/main/java/org/mifos/mobile/ui/fragments/AccountsFragment.kt
Outdated
Show resolved
Hide resolved
Also , I have a doubt . If i click on the filter button without selecting an option should there be any UI layout? I mean if i haven't selected any filter then ideally i should see the screen as it is. Why will i need a UI layout with the message "No Accounts Found" ? |
@PratyushSingh07 yes you are right cancle.mp4By the way I am Manikanta from Dayananda Sagar college of Engineering (5th sem) |
d21bd95
to
39aecea
Compare
If i click on filter button without selecting any option then seeing the screen as it is should be a better alternative. Also, do not resolve the conversation . let the reviewer do it |
@PratyushSingh07 I have made screen remain same after selecting no options in filter filter.mp4 |
fix openMF#1665: Filter error in AccountsFragment.kt fixed fix openMF#1665: Filter error in AccountsFragment.kt fixed fix openMF#1665: Filter error in AccountsFragment.kt fixed fix openMF#1665: Filter error in AccountsFragment.kt fixed
d9fa04a
to
64c9989
Compare
@therajanmaurya pls merge this too |
LGTM we can merge this @therajanmaurya |
Fixes #1665
Please Add Screenshots If there are any UI changes.
1665.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
✅ Apply the
AndroidStyle.xml
style template to your code in Android Studio.✅ Run the unit tests with
./gradlew check
to make sure you didn't break anything✅ If you have multiple commits please combine them into one commit by squashing them.