CI fixes

openPMD · Apr 4, 2022 · 83ef5f4 · 83ef5f4
1 parent 46747db
commit 83ef5f4
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 8 deletions.
diff --git a/include/openPMD/backend/Writable.hpp b/include/openPMD/backend/Writable.hpp
@@ -121,9 +121,9 @@ OPENPMD_private
      */
     std::shared_ptr<AbstractFilePosition> abstractFilePosition;
     std::shared_ptr<AbstractIOHandler> IOHandler;
-    internal::AttributableData *attributable;
-    Writable *parent;
-    bool dirty;
+    internal::AttributableData *attributable = nullptr;
+    Writable *parent = nullptr;
+    bool dirty = false;
     /**
      * If parent is not null, then this is a vector of keys such that:
      * &(*parent)[key_1]...[key_n] == this
@@ -146,6 +146,6 @@ OPENPMD_private
      * Writable and its meaning within the current dataset.
      *
      */
-    bool written;
+    bool written = false;
 };
 } // namespace openPMD
diff --git a/src/Iteration.cpp b/src/Iteration.cpp
@@ -237,9 +237,15 @@ void Iteration::flushFileBased(
         s.openIteration(i, *this);
     }
 
-    if (flushParams.flushLevel != FlushLevel::CreateOrOpenFiles)
+    switch (flushParams.flushLevel)
     {
+    case FlushLevel::CreateOrOpenFiles:
+        break;
+    case FlushLevel::SkeletonOnly:
+    case FlushLevel::InternalFlush:
+    case FlushLevel::UserFlush:
         flush(flushParams);
+        break;
     }
 }
 
@@ -254,9 +260,15 @@ void Iteration::flushGroupBased(
         IOHandler()->enqueue(IOTask(this, pCreate));
     }
 
-    if (flushParams.flushLevel != FlushLevel::CreateOrOpenFiles)
+    switch (flushParams.flushLevel)
     {
+    case FlushLevel::CreateOrOpenFiles:
+        break;
+    case FlushLevel::SkeletonOnly:
+    case FlushLevel::InternalFlush:
+    case FlushLevel::UserFlush:
         flush(flushParams);
+        break;
     }
 }
 
@@ -272,9 +284,15 @@ void Iteration::flushVariableBased(
         this->setAttribute("snapshot", i);
     }
 
-    if (flushParams.flushLevel != FlushLevel::CreateOrOpenFiles)
+    switch (flushParams.flushLevel)
     {
+    case FlushLevel::CreateOrOpenFiles:
+        break;
+    case FlushLevel::SkeletonOnly:
+    case FlushLevel::InternalFlush:
+    case FlushLevel::UserFlush:
         flush(flushParams);
+        break;
     }
 }
 

diff --git a/src/backend/Attributable.cpp b/src/backend/Attributable.cpp
@@ -213,9 +213,15 @@ void Attributable::seriesFlush(internal::FlushParams flushParams)
 
 void Attributable::flushAttributes(internal::FlushParams const &flushParams)
 {
-    if (flushParams.flushLevel == FlushLevel::SkeletonOnly)
+    switch (flushParams.flushLevel)
     {
+    case FlushLevel::SkeletonOnly:
+    case FlushLevel::CreateOrOpenFiles:
         return;
+    case FlushLevel::InternalFlush:
+    case FlushLevel::UserFlush:
+        // pass
+        break;
     }
     if (dirty())
     {