Remove constexpr from RecordComponent::visit() (#1582)

RecordComponent has a virtual base class, so it cannot be constexpr
openPMD · Dec 22, 2023 · a3fe9b7 · a3fe9b7
1 parent 7296948
commit a3fe9b7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/include/openPMD/RecordComponent.hpp b/include/openPMD/RecordComponent.hpp
@@ -476,9 +476,8 @@ class RecordComponent : public BaseRecordComponent
      *         be implicitly converted.
      */
     template <typename Visitor, typename... Args>
-    constexpr auto visit(Args &&...args)
-        -> decltype(Visitor::template call<char>(
-            std::declval<RecordComponent &>(), std::forward<Args>(args)...));
+    auto visit(Args &&...args) -> decltype(Visitor::template call<char>(
+        std::declval<RecordComponent &>(), std::forward<Args>(args)...));
 
     static constexpr char const *const SCALAR = "\vScalar";
 

diff --git a/include/openPMD/RecordComponent.tpp b/include/openPMD/RecordComponent.tpp
@@ -397,7 +397,7 @@ namespace detail
 } // namespace detail
 
 template <typename Visitor, typename... Args>
-constexpr auto RecordComponent::visit(Args &&...args)
+auto RecordComponent::visit(Args &&...args)
     -> decltype(Visitor::template call<char>(
         std::declval<RecordComponent &>(), std::forward<Args>(args)...))
 {