Skip to content

Commit

Permalink
Disable compression on HDF5 datasets
Browse files Browse the repository at this point in the history
Ignore HDF5 dataset compression and transformation for the moment to
sidestep further backend problems.
  • Loading branch information
C0nsultant committed Apr 11, 2018
1 parent 32d9a37 commit abefc3c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
8 changes: 3 additions & 5 deletions src/IO/AbstractIOHandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,17 @@ AbstractIOHandler::createIOHandler(std::string const& path,
{
case Format::HDF5:
# if openPMD_HAVE_HDF5
ret = std::make_shared< ParallelHDF5IOHandler >(path, at, comm);
return std::make_shared< ParallelHDF5IOHandler >(path, at, comm);
# else
std::cerr << "Parallel HDF5 backend not found. "
<< "Your IO operations will be NOOPS!" << std::endl;
ret = std::make_shared< DummyIOHandler >(path, at);
return std::make_shared< DummyIOHandler >(path, at);
# endif
break;
case Format::ADIOS1:
case Format::ADIOS2:
std::cerr << "Parallel ADIOS2 backend not yet working. "
<< "Your IO operations will be NOOPS!" << std::endl;
ret = std::make_shared< DummyIOHandler >(path, at);
break;
return std::make_shared< DummyIOHandler >(path, at);
default:
return std::make_shared< DummyIOHandler >(path, at);
}
Expand Down
4 changes: 4 additions & 0 deletions src/IO/HDF5/HDF5IOHandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,9 @@ HDF5IOHandlerImpl::createDataset(Writable* writable,

std::string const& compression = parameters.compression;
if( !compression.empty() )
std::cerr << "Compression not yet implemented in HDF5 backend."
<< std::endl;
/*
{
std::vector< std::string > args = auxiliary::split(compression, ":");
std::string const& format = args[0];
Expand All @@ -256,6 +259,7 @@ HDF5IOHandlerImpl::createDataset(Writable* writable,
<< " unknown. Data will not be compressed!"
<< std::endl;
}
*/

std::string const& transform = parameters.transform;
if( !transform.empty() )
Expand Down

0 comments on commit abefc3c

Please sign in to comment.