Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set permissions for firebase hosting preview #886

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

herablog
Copy link
Member

Pull Request上でFirebase HostingのPreviewをする上で必要なpermissionsを設定しました。

検証は以下のブランチ (PR) でしています。
#885

@herablog herablog requested a review from sasaplus1 December 26, 2023 09:02
@herablog herablog self-assigned this Dec 26, 2023
Copy link
Member

@sasaplus1 sasaplus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.github.com/ja/actions/using-jobs/assigning-permissions-to-jobs を読みつつ確認しましたが結局のところjobの結果を見ないとわからなそうだなと思いました😅 既に検証していただいているので大丈夫だと思いますが……

@herablog
Copy link
Member Author

そうなんですよね・・unclearなので・・:ase:

権限なし状態から必要と思われるもの足したので大丈夫だとは思いますが・・ 🙏

@herablog herablog merged commit c7ed4cb into main Dec 26, 2023
7 checks passed
@herablog herablog deleted the ci/permissions-preview branch December 26, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants