-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix query and path params not keeping the coerced types #262
Fix query and path params not keeping the coerced types #262
Conversation
|
This pull request introduces 1 alert when merging 1ab18a7 into 2d7a470 - view on LGTM.com new alerts:
|
dc4ca4c
to
b191215
Compare
@anttiviljami Do we expect a fix, like this PR is suppose to address, likely to happen? Does this PR need to be updated? As I see it is a year old? |
Superceded by #571 |
This is to fix requests not saving with the correct types.
NOTE: This is only for query parameters, to my understanding path parameters are not being serialized at all. See line 307 in src/router.tstypescript{
name: queryParam,
in: 'query',
},
Update: I realized coercing query parameters and path parameters use the exact same logic so I changed this to coerce both types.
#144