Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make much more flexible #1

Merged
merged 2 commits into from
Oct 29, 2015
Merged

make much more flexible #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1fcc25
make much more flexible
bewest Oct 21, 2015
03ac992
only add date FIELDNAMES to config if there is one
bewest Oct 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 28 additions & 6 deletions openapscontrib/timezones/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import argparse
from dateutil.tz import gettz
from dateutil.parser import parse
from datetime import datetime

def set_config (args, device):
return device
Expand All @@ -22,26 +23,47 @@ def display_device (device):

class ConvertInput (Use):
FIELDNAME = ['date']
def to_ini (self, args):
params = self.get_params(args)
now = datetime.now( ).replace(tzinfo=args.timezone)
params['timezone'] = now.tzname( )
if args.date:
params['date'] = ' '.join(args.date)
return params
def from_ini (self, fields):
fields['date'] = fields['date'].split(' ')
zone = fields.get('timezone', None)
if zone in ['None', None]:
zone = gettz( )
else:
zone = gettz(zone)
fields['timezone'] = zone
fields['astimezone'] = fields.get('astimezone', False) is 'True'
return fields
def get_params (self, args):
return dict(input=args.input, timezone=args.timezone, adjust=args.adjust, field=args.field)
return dict(input=args.input, timezone=args.timezone, adjust=args.adjust, date=args.date, astimezone=args.astimezone)
def configure_app (self, app, parser):
parser.add_argument('--timezone','-z', default=gettz( ), type=gettz)
parser.add_argument('--adjust','-a', default='missing', choices=['missing', 'replace'])
parser.add_argument('--field','-f', action='append', default=self.FIELDNAME)
parser.add_argument('--date','-d', action='append', default=self.FIELDNAME)
parser.add_argument('--astimezone','-r', action='store_true', default=False)
parser.add_argument('input', default='-')
def get_program (self, args):
params = self.get_params(args)
program = json.load(argparse.FileType('r')(params.get('input')))
return program
def set_converter (self, args):
params = self.get_params(args)
self.FIELDNAME = params.get('field')
self.FIELDNAME = params.get('date')
self.adjust = params.get('adjust')
self.timezone = params.get('timezone')
self.astimezone = params.get('astimezone')

def rezone (self, dt):
if (self.adjust == 'missing' and dt.tzinfo == None) or self.adjust == 'replace':
return dt.replace(tzinfo=self.timezone)
dt = dt.replace(tzinfo=self.timezone) # .astimezone(self.timezone)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replaces the timezone, such that the "datetime" expressed is now in this new timezone rather than the old one.

When a datetime that does not know about a timezone gains the ability to reason about timezones, calling isoformat( ) on the object will result in the similar behavior as javascript's dt.toISOString( ): the date will be rendered as iso 8601, in Zulu/UTC timezone, with the hours shifted from the local timezone appropriately. The inverse happens with parsing a zone-aware iso8601 string: the parser determines the difference between your local time and the described zone, and produces the correct wall-time as a result. By default, printing it out again will shift it back to the "canonical" Zulu/UTC zone-aware representation. While the tools heavily prefer UTC/Zulu time, it can be useful to print iso8601 date strings with the local time correctly described locally.

The following dt.astimezone line, in contrast, "shifts" the hours from timezone A to timezone B appropriately while pinning the behavior of isoformat( ) to produce an iso8601 format in the new timezone (not Zulu/UTC). This can be useful in printing a valid zone-aware 8601 string in the local time, given a valid is8601 datetime that is already (correctly) zone aware in another zone, or missing a zone altogether.

These two behaviors can be invoked by the tool independently, to control whether or not to shift times vs simply printing them in local time vs UTC time.

if self.astimezone:
dt = dt.astimezone(self.timezone)
return dt
def range (self, program):
return [ program ]
Expand Down Expand Up @@ -85,9 +107,9 @@ def range (self, program):
@use( )
class rezone (glucose):
"""
Manage timezones on glucose times.
Manage how timezones are expressed in data.
"""
FIELDNAME = ['timestamp', 'dateString', 'start_at', 'end_at', 'created_at']
FIELDNAME = ['timestamp', 'dateString', 'start_at', 'end_at', 'created_at' ]


def get_uses (device, config):
Expand Down