injector image registry value used for agentImage image registry

[michel-thebeau-WR]

Describe the bug
The templates/injector-deployment.yaml uses injector.image.registry instead of injector.agentImage.registry for the value of AGENT_INJECT_VAULT_IMAGE.

To Reproduce
Steps to reproduce the behavior:

1. Install chart, etc
2. Observe that inject pod config AGENT_INJECT_VAULT_IMAGE value is incorrect (docker.io instead of quay.io for registry)
3. and/or run a openbao unaware application, and observe that it doesn't get init container added by webhook

(reporter is testing under kubernetes, opendev/starlingx project)

Expected behavior
Inject agent image name is rendered with quay.io (not docker.io)

Environment

• Kubernetes version:
  • 1.29.2
  • integrating openbao into opendev/starlingx
• openbao-helm version: tag 0.7.0;
• and observed on openbao-helm main branch:

  openbao-helm/charts/openbao/templates/injector-deployment.yaml

  Line 72 in b73f988

  value: "{{ .Values.injector.image.registry | default "quay.io" }}/{{ .Values.injector.agentImage.repository }}:{{ .Values.injector.agentImage.tag }}"

Chart values:

default chart values, as from values.yaml.

Additional context
The opendev/starlingx developer uses this patch to fix openbao 0.7.0:
https://review.opendev.org/c/starlingx/app-openbao/+/935703/17/helm-charts/upstream/openbao-helm/debian/deb_folder/patches/0003-Fix-agent-image-registry-in-injector-deployment.patch#25