Fix agent image registry in injector deployment #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried running the tests mentioned in CONTRIBUTING.md. Had to twiddle the image to docker.io/alpine:latest instead of docker.mirror.hashicorp.services/alpine:latest; but otherwise tests seemed to pass. |
|
Thanks Mitch for opening the pull request. |
The value for AGENT_INJECT_VAULT_IMAGE in injector-deployment.yaml incorrectly points to injector image's registry instead of the agent image registry. This changes the registry to the correct agent image one, so the agent image variable points to the correct image. Signed-off-by: Tae Park <[email protected]> Signed-off-by: Michel Thebeau <[email protected]>
JanMa
force-pushed
the
michelthebeau/bug31/main
branch
from
912a959 to
fda9472
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value for AGENT_INJECT_VAULT_IMAGE in injector-deployment.yaml incorrectly points to injector image's registry instead of the agent image registry. This changes the registry to the correct agent image one, so the agent image variable points to the correct image.
Issue #31