Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added files end point to vault (CADC-12561) #217

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Added files end point to vault (CADC-12561) #217

merged 5 commits into from
Feb 8, 2024

Conversation

andamian
Copy link
Contributor

@andamian andamian commented Feb 5, 2024

No description provided.

pdowler
pdowler requested changes Feb 6, 2024
View reviewed changes
Copy link
Member

@pdowler pdowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like using subclassing to slightly optimise code for actions on different endpoints. It ends up being hard to maintain... better for the "files" code in cavern to be independent of "nodes" code (from the lib). Same will apply to vault.

cadc-vos-server/build.gradle Outdated Show resolved Hide resolved
cadc-vos-server/src/main/java/org/opencadc/vospace/server/actions/NodeAction.java Outdated Show resolved Hide resolved
cavern/src/main/java/org/opencadc/cavern/files/FileAction.java Outdated Show resolved Hide resolved
pdowler
pdowler requested changes Feb 7, 2024
View reviewed changes
cadc-test-vos/src/main/java/org/opencadc/conformance/vos/FilesTest.java Outdated Show resolved Hide resolved
cadc-test-vos/src/main/java/org/opencadc/conformance/vos/FilesTest.java Outdated Show resolved Hide resolved
cadc-test-vos/src/main/java/org/opencadc/conformance/vos/NodesTest.java Outdated Show resolved Hide resolved
cadc-vos-server/src/main/java/org/opencadc/vospace/server/actions/BaseFileAction.java Outdated Show resolved Hide resolved
cadc-vos-server/src/main/java/org/opencadc/vospace/server/actions/NodeAction.java Outdated Show resolved Hide resolved
cadc-vos-server/src/main/java/org/opencadc/vospace/server/actions/NodeAction.java Outdated Show resolved Hide resolved
cavern/src/main/java/org/opencadc/cavern/files/FileAction.java Outdated Show resolved Hide resolved
@pdowler pdowler merged commit 55a22fc into opencadc:master Feb 8, 2024
1 check passed
@andamian andamian deleted the CADC-12561 branch March 6, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdowler pdowler pdowler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andamian @pdowler