Fixes for serverless HLS #627
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KatrinIhler
force-pushed
the
263-hls-fixes
branch
from
9e54332 to
3869297
Compare
JulianKniephoff
requested changes
Sep 5, 2024
| @@ -159,6 +159,7 @@ define([ | |||
| RegExp.prototype.test.bind(/application\/.*|video\/.*/), | |||
| _.property("mimetype") | |||
| )); | |||
| videos = _.sortBy(videos, "master").reverse(); | |||
There was a problem hiding this comment.
Can we integrate this in the sort below? Something like
videos.sort(
util.lexicographical([
util.firstWith(
_.property("master")
),
// [...]
])
);Should work, but please double-check me on this.
| renderers: ["html5", "native_hls"], | ||
| renderers: ["native_hls", "html5"], |
There was a problem hiding this comment.
Is this necessary even with the correct sort order of the videos? 🤔
Looking at the docs for this setting I also wonder: Can we get away with not specifying this at all?
| if (isNaN(self.getDuration()) || mediaElement.readyState < 1) { | ||
| if (!isFinite(self.getDuration()) || mediaElement.readyState < 1) { |
There was a problem hiding this comment.
Wouldn't live streams have infinite durations? 🤔 Although to be fair, the rest of the tool can't deal with those, either. x)
Still, I wonder: Did you encounter a case where the duration is infinite first, and then changes to something finite?
|
Pinging @luniki to look at this review since he is the original author of the patch IIRC. |
marwyg
added a commit
to marwyg/annotation-tool
that referenced
this pull request
Nov 15, 2024
PR opencast#627: Fixes for serverless HLS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual changes from @luniki.