-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate waveform from track in specified flavor #694
base: main
Are you sure you want to change the base?
Generate waveform from track in specified flavor #694
Conversation
This pull request is deployed at test.editor.opencast.org/694/2022-05-17_15-41-22/ . |
Do we still want/need this with the other one merged? We know that we still have problems with large files even with this merged. What do you think? |
This pull request has conflicts ☹ |
…for-waveform-generation
This pull request is deployed at test.editor.opencast.org/694/2022-06-15_07-18-09/ . |
I think merging would still be beneficial for the current state of the editor. True, this does not fix the issue with long files in frontend waveform generation. But currently, the only real solution to that seems to be to not use frontend waveform generation at all. By that logic, we should probably remove all code pertaining to waveform generation, but we haven't. Until we decide to do that, this PR helps users who want to use frontend waveform generation (and don't have long video files). |
This pull request has conflicts ☹ |
…for-waveform-generation
This pull request is deployed at test.editor.opencast.org/694/2022-07-06_09-04-21/ . |
This pull request has conflicts ☹ |
…for-waveform-generation
This pull request is deployed at test.editor.opencast.org/694/2022-10-06_15-30-16/ . |
This pull request has conflicts ☹ |
…for-waveform-generation
This pull request is deployed at test.editor.opencast.org/694/2022-10-14_09-16-43/ . |
This pull request has conflicts ☹ |
…for-waveform-generation
This pull request is deployed at test.editor.opencast.org/694/2024-01-18_15-49-12/ . |
This pull request has conflicts ☹ |
…for-waveform-generation
This pull request is deployed at test.editor.opencast.org/694/2024-01-29_15-29-49/ . |
Test failures. :( |
This pull request has conflicts ☹ |
Adds a new setting that allows the user to specify a flavor from which the waveform image will be generated. Since the waveform generation normally requires fetching a whole video file, this allows specifying a way smaller audio file, thereby reducing traffic.
One way to generate an audio file in Opencast
Example for an Opencast workflow operation for generating an audio file
Example for an Opencast encoding profile for a generating a small audio file
Using a small audio file instead of a video file speeds up the waveform generation, but not as much as maybe desirable. For example, for a video file of 80 minutes and 125 MB, waveform generation took 20 seconds. With an audio file generated from the video with 7 MB, waveform generation still took 10 seconds.
This does NOT solve the issue of the editor crashing for very long videos (over ~3 hours). The crashing does seem to be related to workflow generation though, particularly to audio decoding.