Revert "Replace img by next img homepage only" #6169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 63d3ee2.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/opencollective/opencollective-frontend/58Q7PQ2EWS3BLTkzkp6BG7YFgodt |
|
@SudharakaP that sounds good, let's investigate the next.js update then! |
SudharakaP
deleted the
revert-6140-replace-img-by-next-img-homepage-only
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6140
@znarf @Betree : I investigated the memory exceeding problem with the
next/image(as mentioned in the slack channel; https://opencollective.slack.com/archives/CEZUS9WH3/p1618327036004800) and my thinking is the current nextjs version we are using has some bugs. This problem was reported several times where the memory is exceeding in the optimization phase;vercel/next.js#23189
vercel/next.js#22925
Now it seems they have fixed this problem in v10.1.3 however our update to that is blocked due to breaking builds; #6149.
So,
When CI passes I will merge this reversion so that we can have a solid build.
Will investigate what we could do get the nextjs upgrade done so that we can retry this again. 😄