Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACL actions for setting inner MACs #2079

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marian-pritsak
Copy link
Contributor

Add actions SET_INNER_SRC_MAC and SET_INNER_DST_MAC for tunneled packets to be able to override inner
values independently from router based on ACL policy.

Add actions SET_INNER_SRC_MAC and SET_INNER_DST_MAC
for tunneled packets to be able to override inner
values independently from router based on ACL policy.

Signed-off-by: Marian Pritsak <[email protected]>
@tjchadaga tjchadaga added the reviewed PR is discussed in SAI Meeting label Dec 20, 2024
@tjchadaga
Copy link
Collaborator

@JaiOCP, @rck-innovium - Could you please help review/sign off on this?

@mclayto
Copy link

mclayto commented Jan 17, 2025

Can we clarify the intended behavior for these in both encap and transit scenarios across the various ACL stages? For example, in an ingress ACL in an encap flow where there is no INNER yet but there will be before egress, do these actions apply to the soon-to-be-inner? Or are these actions only valid on egress in an encap flow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed PR is discussed in SAI Meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants