-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for creating/modifying IPMC group with member list. #2121
Open
erohsik
wants to merge
1
commit into
opencomputeproject:master
Choose a base branch
from
erohsik:ipmcgroup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
### IP Multicast Group with members | ||
|
||
Allow IP Multicast Group to be created/modified by specifying the list of members | ||
|
||
### Motivation | ||
|
||
The existing IPMC workflow | ||
* Create a IPMC group | ||
* Add/remove members to this group | ||
|
||
We describe a sample workflow | ||
* A is added to the group | ||
* B is added to the group | ||
* The path to A goes down, so an alternate member A' is added | ||
* Subsequently the primary path to A is restored, so A' needs to be swapped with A | ||
|
||
We have two ways to acheive this. | ||
* remove A' and then add A leading to a small window where no traffic is received by the receiver. | ||
* add A and then remove A' leading to a small window wheret duplicate traffic is received. | ||
|
||
We'd like to avoid both of these scenarios. | ||
|
||
### Proposal | ||
|
||
Specify the full current list of multicast group members at create and update time. | ||
|
||
* Introduce an attribute specifying that the IPMC group members are specified upfront. | ||
* Add a IPMC group attribute for the list of members | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,6 +60,26 @@ typedef enum _sai_ipmc_group_attr_t | |
*/ | ||
SAI_IPMC_GROUP_ATTR_IPMC_MEMBER_LIST, | ||
|
||
/** | ||
* @brief Flag indicating that the member list is specified at create time | ||
* | ||
* @type bool | ||
* @flags CREATE_ONLY | ||
* @default false | ||
*/ | ||
SAI_IPMC_GROUP_ATTR_IPMC_GROUP_WITH_MEMBERS, | ||
|
||
/** | ||
* @brief IPMC output list | ||
* | ||
* @type sai_object_list_t | ||
* @flags CREATE_AND_SET | ||
* @objects SAI_OBJECT_TYPE_NEXT_HOP | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why only nexthop, IPMC member create support RIF, Tunnel also There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IIUC the object list check requires the list to contain a single object type.. |
||
* @default empty | ||
* @validonly SAI_IPMC_GROUP_ATTR_IPMC_GROUP_WITH_MEMBERS == true | ||
*/ | ||
SAI_IPMC_GROUP_ATTR_IPMC_OUTPUT_LIST, | ||
|
||
/** | ||
* @brief End of attributes | ||
*/ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per your design, NOS should send all members during SET so that SAI can replace all existing members, that is not captured here