Fill control origin #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case "inherited": | ||
| return inheritedOrigination | ||
| } | ||
| return noOrigin |
There was a problem hiding this comment.
Can we simplify this and the variables above to simply be a map from the origin key to the document substring?
|
All looks good! Just a couple small things. |
jcscottiii
force-pushed
the
fill-control-origin
branch
from
5194ce9 to
8f4cf44
Compare
added 2 commits
September 1, 2016 12:07
| type originMapping struct { | ||
| yamlMapping string | ||
| docMapping string | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #42. Delivers #26.
This PR introduces filling of the control origination checkbox based on the values in the opencontrol yaml.
The logic for unchecking is there but the logic for WHEN to uncheck will be addressed in #45