Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/cleanup #196

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Chore/cleanup #196

merged 4 commits into from
Dec 19, 2024

Conversation

wietzesuijker
Copy link
Contributor

Cleanup changes split from another PR:

  • This changes the default from python 3.8 to python 3.10 for the dev env (following what is used in the .github/workflows).
  • Changes spelling defaults from words like finalize to finalise (sorry for the UK push, happy to go the other way, just want consistency)
  • add some docstrings to functions
  • use built in types for dict, list and tuple rather than from typing import Dict, List, Tuple. This is not implemented library-wide here, as I was only touching some files for the other PR. Arguably using Optional can also be dropped, as var[list[str]] = None is valid python.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.48%. Comparing base (5da3ea1) to head (f780b0f).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
odc/geo/cog/_s3.py 42.85% 4 Missing ⚠️
odc/geo/cog/_tifffile.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #196      +/-   ##
===========================================
+ Coverage    95.44%   95.48%   +0.03%     
===========================================
  Files           31       31              
  Lines         5534     5532       -2     
===========================================
  Hits          5282     5282              
+ Misses         252      250       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

odc/geo/cog/_tifffile.py Outdated Show resolved Hide resolved
@Kirill888
Copy link
Member

@wietzesuijker thanks for this, it should make it easier to review the other PR. Please address one last thing, and then we can merge and focus on the real change in the other PR.

odc/geo/cog/_tifffile.py Outdated Show resolved Hide resolved
odc/geo/cog/_tifffile.py Outdated Show resolved Hide resolved
odc/geo/cog/_tifffile.py Outdated Show resolved Hide resolved
@wietzesuijker
Copy link
Contributor Author

ready to merge :)

@Kirill888 Kirill888 merged commit ade0406 into opendatacube:develop Dec 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants