-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/cleanup #196
Chore/cleanup #196
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #196 +/- ##
===========================================
+ Coverage 95.44% 95.48% +0.03%
===========================================
Files 31 31
Lines 5534 5532 -2
===========================================
Hits 5282 5282
+ Misses 252 250 -2 ☔ View full report in Codecov by Sentry. |
@wietzesuijker thanks for this, it should make it easier to review the other PR. Please address one last thing, and then we can merge and focus on the real change in the other PR. |
533d5ac
to
9cf70f7
Compare
9cf70f7
to
f780b0f
Compare
ready to merge :) |
Cleanup changes split from another PR:
finalize
tofinalise
(sorry for the UK push, happy to go the other way, just want consistency)Optional
can also be dropped, asvar[list[str]] = None
is valid python.