Refacto search pages #633
Open
Refacto search pages #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ecospheres ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for meteo-france ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| const route = useRoute() | ||
| const router = useRouter() | ||
|
|
||
| const discussionStore = useDiscussionStore() | ||
| const userStore = useUserStore() | ||
|
|
||
| const { topicsName } = useTopicsConf() | ||
| // const { searchPageName } = useSearchPagesConfig( |
There was a problem hiding this comment.
ça posait un bug, à corriger avant merge
| @@ -44,8 +46,7 @@ const props = defineProps({ | |||
| }) | |||
|
|
|||
| const subjectClassLabels = { | |||
| Dataset: 'jeu de données', | |||
| Topic: topicsName | |||
| Dataset: 'jeu de données' | |||
There was a problem hiding this comment.
à corriger avant merge
| @@ -57,7 +57,7 @@ const badgeClasse = computed(() => { | |||
| <DsfrBadge | |||
| v-if="alreadySelected" | |||
| type="info" | |||
| label="Déjà utilisé dans ce bouquet" | |||
| label="Déjà utilisé dans ce topic" | |||
There was a problem hiding this comment.
à corriger
| @@ -27,5 +23,5 @@ export interface ReuseType { | |||
| // use a const instead of an interface to be compatible with topicsName as a variable | |||
| export const ReuseModel = { | |||
| dataset: 'jeu de donnée', | |||
| topic: topicsName | |||
| topic: 'test' // to fix | |||
There was a problem hiding this comment.
àc orriger
| }) | ||
| }, | ||
| { | ||
| path: ':bid', |
There was a problem hiding this comment.
rajouter une condition pour ne pas ajouter cette objet si type = datasets
| @@ -262,26 +263,26 @@ watch( | |||
| la source originale peuvent avoir été perdues lors de leur | |||
| récupération. Nous travaillons actuellement à améliorer la situation. | |||
| </div> | |||
| <div | |||
| <!-- <div | |||
There was a problem hiding this comment.
à corriger on ne peut plus ajouter un dataset à un bouquet car on ne sait pas quel objet choisir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectif de la PR :
Ce que fait cette PR :
search_configet enlève les config précédentestopics,themesetindicators. Cet objetsearch_configqui est un objet contenant différentes propriétés :Ce qu'il manque :