Ignore recommendation of itself (#147)

opendatateam · Oct 15, 2020 · f3b909a · f3b909a
1 parent 713e636
commit f3b909a
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 ## Current (in progress)
 
-- Nothing yet
+- Ignore recommendation of dataset itself [#147](https://github.com/opendatateam/udata-recommendations/pull/147)
 
 ## 2.1.0 (2020-08-25)
 

diff --git a/tests/test_tasks.py b/tests/test_tasks.py
@@ -176,3 +176,18 @@ def test_datasets_recommendations_from_config_clean(self, mock_response, rmock,
         # Previous recommendations have been cleaned
         ds1.reload()
         assert ds1.extras == {}
+
+    def test_datasets_recommendations_ignore_self_recommendation(self, rmock, datasets):
+        ds1, _, _ = datasets
+        rmock.get(MOCK_URL, json=[{
+            "id": str(ds1.id),
+            "recommendations": [{
+                "id": str(ds1.id),
+                "score": 50
+            }]
+        }])
+
+        recommendations_add({'fake_source': MOCK_URL}, should_clean=True)
+
+        ds1.reload()
+        assert ds1.extras == {}
diff --git a/udata_recommendations/tasks.py b/udata_recommendations/tasks.py
@@ -60,6 +60,8 @@ def process_dataset(source, dataset):
     for reco in dataset['recommendations']:
         try:
             reco_dataset_obj = get_dataset(reco['id'])
+            if reco_dataset_obj.id == target_dataset.id:
+                continue
             valid_recos.append({
                 'id': str(reco_dataset_obj.id),
                 'score': reco['score'],