-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updated Elevation and Responsive docs #3335
base: release-23.x
Are you sure you want to change the base?
docs: updated Elevation and Responsive docs #3335
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2563e39
to
86c3bac
Compare
@@ -99,6 +124,57 @@ function Responsive({ pageContext }) { | |||
<CodeBlock className="language-scss"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On this page I am not sure if it is worth deleting information that relates to SCSS variables. Any thoughts?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-23.x #3335 +/- ##
=============================================
Coverage 93.91% 93.91%
=============================================
Files 232 232
Lines 3943 3943
Branches 933 933
=============================================
Hits 3703 3703
Misses 236 236
Partials 4 4 ☔ View full report in Codecov by Sentry. |
86c3bac
to
d6ce36a
Compare
✅ Deploy Preview for paragon-openedx-v23 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
On the alpha version of the Paragon documentation site, on the Elevation and Responsive pages, there is not enough complete information about the innovations that have appeared in Paragon (CSS variables).
Issue: #3171
Merge Checklist
example
app?Post-merge Checklist