Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: sync v22 and v23 #3370

Merged
merged 2 commits into from
Dec 18, 2024
Merged

build: sync v22 and v23 #3370

merged 2 commits into from
Dec 18, 2024

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Dec 18, 2024

Description

Syncs commits from release-22.x to release-23.x, without auto-approval and automerge.

Deploy Preview

n/a

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for paragon-openedx-v22 ready!

Name Link
🔨 Latest commit baeb1be
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx-v22/deploys/6762ea9ec703bc00094c6c42
😎 Deploy Preview https://deploy-preview-3370--paragon-openedx-v22.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.43%. Comparing base (f3b0554) to head (baeb1be).
Report is 1 commits behind head on release-22.x.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-22.x    #3370   +/-   ##
=============================================
  Coverage         93.43%   93.43%           
=============================================
  Files               251      251           
  Lines              4522     4522           
  Branches           1057     1052    -5     
=============================================
  Hits               4225     4225           
  Misses              290      290           
  Partials              7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@adamstankiewicz adamstankiewicz merged commit b2da298 into release-22.x Dec 18, 2024
10 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/sync-22-23 branch December 18, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants