-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: account for category hierarchy in loss #79
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the lib eval was removed and as there's no more serving and training model there are some changes needed in the notebooks.
There is also a problematic behaviour of the model in the prediction process:
- the model expects a
compat
key inds_test
. - we don't want the model to apply masks on the outputs during the prediction process.
and run experiment for more iterations as previously
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Loss should account for taxonomy hierarchy