Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: account for category hierarchy in loss #79

Merged
merged 7 commits into from
Sep 7, 2022
Merged

Conversation

alexgarel
Copy link
Member

Loss should account for taxonomy hierarchy

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@alexgarel alexgarel changed the title Ag cat loss feat: account for category hierarchy in loss Jul 6, 2022
Copy link
Contributor

@AnisZakari AnisZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the lib eval was removed and as there's no more serving and training model there are some changes needed in the notebooks.

There is also a problematic behaviour of the model in the prediction process:

  • the model expects a compat key in ds_test.
  • we don't want the model to apply masks on the outputs during the prediction process.

experiments/Train-with-cat-compat-loss.ipynb Outdated Show resolved Hide resolved
experiments/Train-with-cat-compat-loss.ipynb Show resolved Hide resolved
experiments/Train-with-cat-compat-loss.ipynb Outdated Show resolved Hide resolved
experiments/Train-with-cat-compat-loss.ipynb Outdated Show resolved Hide resolved
experiments/Train-with-cat-compat-loss.ipynb Outdated Show resolved Hide resolved
lib/colab.py Outdated Show resolved Hide resolved
lib/colab.py Outdated Show resolved Hide resolved
lib/colab.py Outdated Show resolved Hide resolved
lib/taxonomy.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@alexgarel alexgarel changed the title feat: account for category hierarchy in loss feat: account for category hierarchy in loss Aug 24, 2022
Copy link
Contributor

@AnisZakari AnisZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@AnisZakari AnisZakari merged commit 46a7252 into master Sep 7, 2022
@AnisZakari AnisZakari deleted the ag-cat-loss branch September 7, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants