Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: new policy for variable names #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexgarel
Copy link
Member

What

Talking to people at etalab, they shared this pattern, to use the defaults/ variable file as the "interface" for a role.

I think it's a great idea to avoid confusions.

The proposal is then to

  • always prefix variables with the role name
  • in the role itself, convert variables to unprefixed names and only use that (avoid skipping a declaration)

I found it a really good idea to better track variable usage.
It's open for discussion. I made the PR because it makes the discussion more concrete.

@alexgarel alexgarel requested a review from teleboas January 6, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant