Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pixi-support): add pixi as a conda executable to list package versions #88

Closed
wants to merge 5 commits into from

Conversation

sbtq
Copy link
Contributor

@sbtq sbtq commented Oct 16, 2024

Description

Adds pixi (https://pixi.sh - package manager) as an alternative to list the package versions.
Only as a fallback if micromamba or mamba cannot be found first.

Should add support for #87

Status

  • Ready to go

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.99%. Comparing base (0421f59) to head (5747d0a).
Report is 15 commits behind head on main.

Additional details and impacted files

Copy link
Member

@mattwthompson mattwthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I'll need a little time to learn about pixi before I can really review this, but at a glance this seems like exactly what we're after.

Don't worry about the 👁️=true tests - these require access to a license that we don't expose to forks.

You're right that this behavior isn't tested ... or, more accurately, it's not explicitly a part of any specific tests. It's built into the automation: CI installs different Python distributions by different mechanisms, so in different cases some are and aren't available. There's one for pixi which I'll looking into adding here (no need to do it yourself).

@sbtq
Copy link
Contributor Author

sbtq commented Oct 17, 2024

@mattwthompson ah good point, I see now. If you want I am happy to add that small step to the matrix definition and see if I can make that work. I could probably take a quick look tomorrow.

@sbtq
Copy link
Contributor Author

sbtq commented Oct 21, 2024

@mattwthompson added the necessary pipelines to check the pixi support.
Hope this is fine with you and look forward to your review.

@mattwthompson
Copy link
Member

Looks like expected tests as passing - thanks, will have a look soon

@sbtq
Copy link
Contributor Author

sbtq commented Oct 24, 2024

Looks like expected tests as passing - thanks, will have a look soon

No problem, sorry it took a few tries, missed some (pretty obvious 🤦 ) stuff in the intermediate commits. Glad we got it sorted and it is working now :) 👍

Copy link
Member

@mattwthompson mattwthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % a couple of questions

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
devtools/pixi-envs/pyproject.toml Show resolved Hide resolved
@mattwthompson mattwthompson mentioned this pull request Oct 28, 2024
3 tasks
@sbtq
Copy link
Contributor Author

sbtq commented Nov 11, 2024

Hey @mattwthompson, any updates on this topic? :) 🙏

@sbtq
Copy link
Contributor Author

sbtq commented Dec 3, 2024

hey @mattwthompson any update? :)

@mattwthompson
Copy link
Member

@sbtq could you have a look at #90?

@sbtq
Copy link
Contributor Author

sbtq commented Dec 16, 2024

@sbtq could you have a look at #90?

I think that looks fine.

@mattwthompson
Copy link
Member

This morphed into #90, which will also intersect in some ways with #94

Thanks for the contribution @sbtq, and sorry this took so long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants