-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pixi-support): add pixi as a conda executable to list package versions #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I'll need a little time to learn about pixi
before I can really review this, but at a glance this seems like exactly what we're after.
Don't worry about the 👁️=true
tests - these require access to a license that we don't expose to forks.
You're right that this behavior isn't tested ... or, more accurately, it's not explicitly a part of any specific tests. It's built into the automation: CI installs different Python distributions by different mechanisms, so in different cases some are and aren't available. There's one for pixi
which I'll looking into adding here (no need to do it yourself).
@mattwthompson ah good point, I see now. If you want I am happy to add that small step to the matrix definition and see if I can make that work. I could probably take a quick look tomorrow. |
@mattwthompson added the necessary pipelines to check the pixi support. |
Looks like expected tests as passing - thanks, will have a look soon |
No problem, sorry it took a few tries, missed some (pretty obvious 🤦 ) stuff in the intermediate commits. Glad we got it sorted and it is working now :) 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % a couple of questions
Hey @mattwthompson, any updates on this topic? :) 🙏 |
hey @mattwthompson any update? :) |
Description
Adds pixi (https://pixi.sh - package manager) as an alternative to list the package versions.
Only as a fallback if micromamba or mamba cannot be found first.
Should add support for #87
Status